Backport minor readme changes#5048
Merged
calebcartwright merged 3 commits intorust-lang:masterfrom Oct 30, 2021
Merged
Conversation
Remove comma splice
* Document RUSTFMT env var * Move documentation up * Apply suggestions from code review Co-authored-by: Caleb Cartwright <calebcartwright@users.noreply.github.com> * Fix accedental removal Co-authored-by: Caleb Cartwright <calebcartwright@users.noreply.github.com> # Conflicts: # README.md
calebcartwright
approved these changes
Oct 30, 2021
Member
calebcartwright
left a comment
calebcartwright
left a comment
There was a problem hiding this comment.
These seemed useful to backport even if @calebcartwright is rewriting most of the readme.
Fair point, thank you!
This was referenced Mar 29, 2022
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These seemed useful to backport even if @calebcartwright is rewriting most of the readme.
Just for the protocol, these here I did not backport: